whitespace check bug

[zimbatm]

I think the parser has some trouble parsing this horrible file:

class foo {
  file{'/some/file': content    =>inline_template('
FOO=bar
    '),
    require =>Package[somepackage],
    }
  }

https://gist.github.com/zimbatm/c48ba94108aeb52a79a9

When running puppet-lint on it if fails with the following error:

`gems/puppet-lint-1.1.0/lib/puppet-lint/plugins/check_whitespace.rb:115:in `[]': no implicit conversion from nil to integer (TypeError)`

EDIT: removing the require part doesn't trigger the issue.

[rodjek]

Yikes! Thanks for providing the example, i'll take a look into it.

[zimbatm]

Thanks @rodjek . I found another case that would trigger the same error if it's helpful: https://gist.github.com/zimbatm/18b050f8ea79fdb47e34

[duritong]

I have the same bug with the following file https://github.com/duritong/puppet-apache/blob/076909377eaa3aa41936e3acb7e02a9b5b14d493/manifests/gentoo.pp

[zimbatm]

@duritong just finished cleaning up 15k lines of puppet code so by experience: whenever you see the error, try splitting all the resource properties on it's own lines. puppet-lint seem to get confused when you have a mix of single-line and multi-line properties like you have on line 31.

I also found it helpful to patch the "check_whitespace.rb" file to abort early whenever the error occurred.

          prev_indent_token = resource_tokens[0..idx].rindex { |t| t.type == :INDENT }
          # added this block at line 115
          if prev_indent_token.nil?
            p :PARSER_FAIL
            return
          end
          indent_length = resource_tokens[prev_indent_token].to_manifest.length + token.prev_code_token.to_manifest.length + 2

[duritong]

Thanks! Yeah, this is also what I figured out and wanted to provide another example.

[nvtkaszpir]

I have experienced the same issue when linting below code:

  package { [
    'php5-cli',
    'php5-gd',
    'php5-curl',
    'php5-geoip',
    'php5-memcached',
    'php5-memcache',
    'php5-mysql',
    'php-apc',
    'php5-mcrypt',
    'php5-pgsql',
    ]: ensure => installed,
    require   => Exec['apt update'],
  }

adding newline after colon fixes the issue:

  package { [
    'php5-cli',
    'php5-gd',
    'php5-curl',
    'php5-geoip',
    'php5-memcached',
    'php5-memcache',
    'php5-mysql',
    'php-apc',
    'php5-mcrypt',
    'php5-pgsql',
    ]:
    ensure => installed,
    require   => Exec['apt update'],
  }

[dalen]

Had the same issue on some code that looked similar to this (which also triggers it):

file { [
  'foo',
  'bar',
]: require => [
  File['foobaz'],
  File['barbaz'],
], before => [
  File['foobax'],
  File['barbax'],
]}

[gregsio]

Had the same error with the following code (not indented)

Ini_setting {
ensure => present,
path => "${::settings::confdir}/puppet.conf",
}
ini_setting { 'Configure environmentpath':
section => 'main',
setting => 'environmentpath',
value => '$confdir/environments',
}
ini_setting { 'Configure basemodulepath':
section => 'main',
setting => 'basemodulepath',
value => '$confdir/modules:/opt/puppet/share/puppet/modules',
}

I fixed the issue by indenting the code properly

Ini_setting {
  ensure => present,
  path => "${::settings::confdir}/puppet.conf",
}
ini_setting { 'Configure environmentpath':
  section => 'main',
  setting => 'environmentpath',
  value => '$confdir/environments',
}
ini_setting { 'Configure basemodulepath':
  section => 'main',
  setting => 'basemodulepath',
  value => '$confdir/modules:/opt/puppet/share/puppet/modules',
}

[fxlv]

thanks for the patch suggestion @zimbatm !

[rodjek]

This should be fixed as part of #409 (arrow_alignment check expecting an INDENT token at the start of each line)