From de2476dd24c8f99d57f0b01f98b209b77301dcfc Mon Sep 17 00:00:00 2001 From: Steve Flanders Date: Thu, 13 May 2021 13:24:43 -0400 Subject: [PATCH] Approvers now get Write permission (#88) * Approvers now get Write permission In order to support CODEOWNERS for approvers (no GH action), grant approvers Write access. This follows the OTel model. Addresses #87 * Remove action * Re-add CODEOWNERS template * Fix files * Update specification/templates/.github/CODEOWNERS Co-authored-by: Tyler Yahn * Update specification/templates/.github/CODEOWNERS Co-authored-by: Mateusz Rzeszutek Co-authored-by: Tyler Yahn Co-authored-by: Mateusz Rzeszutek --- specification/repository.md | 6 ++---- specification/templates/.github/CODEOWNERS | 5 +++-- .../.github/workflows/request-reviews.yml | 19 ------------------- 3 files changed, 5 insertions(+), 25 deletions(-) delete mode 100644 specification/templates/.github/workflows/request-reviews.yml diff --git a/specification/repository.md b/specification/repository.md index 7b8d963a890..c7c334464f4 100644 --- a/specification/repository.md +++ b/specification/repository.md @@ -24,7 +24,7 @@ approval is granted, GDI projects MUST NOT cut a GA release. - MUST grant `Maintain` [permission level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization) to maintainers team -- MUST grant `Triage` [permission +- MUST grant `Write` [permission level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization) to approvers team - MUST NOT grant `Write`, `Maintain`, `Admin` [permission @@ -91,9 +91,7 @@ approval is granted, GDI projects MUST NOT cut a GA release. - MUST add [CODE_OF_CONDUCT.md](templates/CODE_OF_CONDUCT.md) - MUST add [CONTRIBUTING.md](templates/CONTRIBUTING.md) - MUST have a [.github/CODEOWNERS](templates/.github/CODEOWNERS) file with a maintainers team -- SHOULD have a - [.github/workflows/request-reviews.yml](templates/.github/workflows/request-reviews.yml) - to automate requesting reviews from approvers +- SHOULD have an approvers team in CODEOWNERS - MUST have an Apache 2.0 `LICENSE` file - SHOULD have a `MIGRATING.md` if applicable - MUST have a `README.md` diff --git a/specification/templates/.github/CODEOWNERS b/specification/templates/.github/CODEOWNERS index feafa685804..f4ee4642338 100644 --- a/specification/templates/.github/CODEOWNERS +++ b/specification/templates/.github/CODEOWNERS @@ -1,5 +1,6 @@ -# Learn about CODEOWNERS file format: # https://help.github.com/en/articles/about-code-owners # # Global Owners -* @signalfx/TEAM-maintainers +* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers + +.github/CODEOWNERS @signalfx/gdi-TEAM-maintainers diff --git a/specification/templates/.github/workflows/request-reviews.yml b/specification/templates/.github/workflows/request-reviews.yml deleted file mode 100644 index 66a9a28add2..00000000000 --- a/specification/templates/.github/workflows/request-reviews.yml +++ /dev/null @@ -1,19 +0,0 @@ -name: Request review on PRs - -on: - pull_request: - types: [ opened ] - -jobs: - request: - name: Request reviews on opened PRs - runs-on: ubuntu-20.04 - permissions: - issues: write - steps: - - name: Create PR review request - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - gh pr edit ${{ github.event.pull_request.html_url }} \ - --add-reviewer signalfx/TEAM-approvers