Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNB+DEV: Updates to nbqa for notebook pre-commit #261

Merged
merged 4 commits into from
Jul 26, 2021

Conversation

scottclowe
Copy link
Member

  • Specify that notebooks should be blackened targeting python 2.7, and >=3.5.
  • Sanity check notebooks with flake8.
  • Fix some flake8 errors in the notebooks.

@scottclowe scottclowe added the ci label Jul 26, 2021
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #261 (e4745bc) into master (f920357) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files           8        8           
  Lines        1209     1209           
  Branches      302      302           
=======================================
  Hits         1138     1138           
  Misses         36       36           
  Partials       35       35           
Flag Coverage Δ
nbsmoke 59.88% <ø> (ø)
unittests 93.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f920357...e4745bc. Read the comment docs.

@scottclowe scottclowe merged commit 10a6cd9 into rochefort-lab:master Jul 26, 2021
@scottclowe scottclowe deleted the dev_nbqa branch July 26, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant