Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT REQUEST #228

Closed
daherlihy opened this issue Jan 24, 2024 · 4 comments
Closed

ENHANCEMENT REQUEST #228

daherlihy opened this issue Jan 24, 2024 · 4 comments

Comments

@daherlihy
Copy link

Problem - When I do a restore that contains config files (for instance the sources.xml, advancedsettings.xml, keymap.xml, etc.), they are not updated immediately in Kodi until I restart it.

Many don't realise this and think the restore feature doesn't work - myself included until I asked [Reddit](https://www.reddit.com/r/kodi/comments/19doxcq/how_do_i_back_up_sources/.

Suggestion/Solution - if/when users restore config files (at the very least), there should be a prompt to advise restarting Kodi so as to see the reflected changes from the restoration.

@daherlihy daherlihy added the bug label Jan 24, 2024
@robweber
Copy link
Owner

Good point. When an advancesettings file is detected in the restore point there user is prompted to restore and restart; however this is not fool proof. There are edge cases where this might not be detected. Checking the modified date for these files post-restore is probably a better method of determining if they've been touched.

@daherlihy
Copy link
Author

Thanks for looking into this. I'll leave it up to you to decide whatever is best - I'm just glad I know and want to share the knowledge for anyone else who doesn't know :)

@robweber
Copy link
Owner

I ended up adding a global prompt at the end of all restore jobs to recommend Kodi is restarted. Keeping track of all the files that may require a restart is way too work intensive. Easier to just clean reboot the whole system no matter what.

@daherlihy
Copy link
Author

Yep makes perfect sense, thanks again for the update and for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants