Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for sequenceExpectations of api-fluent #657

Closed
3 tasks
robstoll opened this issue Oct 20, 2020 · 4 comments · Fixed by #1000
Closed
3 tasks

add samples for sequenceExpectations of api-fluent #657

robstoll opened this issue Oct 20, 2020 · 4 comments · Fixed by #1000
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 20, 2020

Code related feature

See for the initial request: #624

With this issue we want to add samples for sequenceAssertions.kt of api-fluent

Following the things you need to do:

api-fluent

  • create SequenceExpectationSamples in apis/fluent-en_GB/atrium-api-fluent-en_GB-common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples
    • add one function per function in sequenceAssertions.kt (see AnyExpectationSamples)
    • refer to the sample in the KDoc of the corresponding function in sequenceAssertions via @sample (check out toEqual in anyExpectations.kt to see how you have to refer to the sample)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll robstoll changed the title add samples for sequenceAssertions of api-fluent add samples for sequenceExpectations of api-fluent May 20, 2021
@logesh-sahaj
Copy link

I'll work on this

@logesh-sahaj
Copy link

Hi @robstoll Can you please assign this to my other id @loge1998

@robstoll
Copy link
Owner Author

robstoll commented Oct 5, 2021

@logesh-sahaj I am afraid but I cannot, you need to post as @loge1998 here (enough if you say "hi" or whatever). Only then I can assign it

@loge1998
Copy link
Contributor

loge1998 commented Oct 5, 2021

Hey I logged in from my personal id

@robstoll robstoll assigned loge1998 and unassigned logesh-sahaj Oct 5, 2021
@robstoll robstoll linked a pull request Oct 9, 2021 that will close this issue
@robstoll robstoll modified the milestones: 0.18.0, 0.17.0 Oct 9, 2021
@robstoll robstoll closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants