Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show only the first 5 mismatches for notToContain/none and all #1101

Open
robstoll opened this issue Mar 2, 2022 · 5 comments
Open

show only the first 5 mismatches for notToContain/none and all #1101

robstoll opened this issue Mar 2, 2022 · 5 comments
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Mar 2, 2022

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

expect((1..100).toList()).notToContain.entry { toBeGreaterThan(2) }

The output will show all elements from 3 to 100 which is way too verbose. Similar to the showOnlyFailing option for toContain.inOrder.only we should introduce NotToContainReportingOptions which allows to setMaxNumberOfMismatches which defaults to 5

@robstoll robstoll changed the title show only the first 10 mismatches for notToContain show only the first 5 mismatches for notToContain Mar 2, 2022
@robstoll robstoll changed the title show only the first 5 mismatches for notToContain show only the first 5 mismatches for notToContain/none and all Mar 2, 2022
@robstoll robstoll modified the milestones: 0.18.0, 0.19.0 Apr 9, 2022
@robstoll robstoll self-assigned this Apr 9, 2022
@robstoll robstoll modified the milestones: 0.19.0, 0.20.0 Dec 29, 2022
@robstoll robstoll modified the milestones: 1.1.0, 1.2.0 Oct 14, 2023
@robstoll robstoll modified the milestones: 1.2.0, 1.3.0 Feb 6, 2024
@WesleyJammer
Copy link

hey, i am pretty new with opensource and for a school project i have to work on an opensource project. i am curious if this issue is still open and if so, i can work on it?

@robstoll
Copy link
Owner Author

@WesleyJammer I already started this one but there are other issues you could work on. have a look at good first issues. You could for instance work on #1887
Let me know in case you need help or prefer something different, I am sure we can find something.

@WesleyJammer
Copy link

@robstoll thanks for the reply! I will look at issue #1887 and discus with my teacher if this issue fits the assignment.

@WesleyJammer
Copy link

@robstoll is it mabye an option if i take #1364 ?

@robstoll
Copy link
Owner Author

This won't be an easy one. you will have to base your work on a feature branch and do part of the on-going migration. Fixing the bug should then be relatively easy.
Write in the other issue if you are still motivated (this way I can assign the task to you).
Alternatively, look at the following issues:
https://github.com/robstoll/atrium/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22help%20wanted%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants