Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement teleportation onGameEnd #6

Open
ghost opened this issue Mar 31, 2018 · 15 comments
Open

Implement teleportation onGameEnd #6

ghost opened this issue Mar 31, 2018 · 15 comments
Milestone

Comments

@ghost
Copy link

ghost commented Mar 31, 2018

make it when the game ends the player gets teleported back to the world spawn and his inventory gets cleared

@ghost
Copy link
Author

ghost commented Mar 31, 2018

the one above is necessary, then comes this one:

add a count down for the game which is on a popup and the count down must be like 100 second or 70

@robske110
Copy link
Owner

The inventories should be cleared already: https://github.com/robske110/TicTacToe/blob/master/TicTacToe/src/robske_110/TTT/Game/Game.php#L259. If that's not the case, please let me know.
I'll implement a teleportation onGameEnd soon.
For the other feature request, do you mean during the game (so that you will only have a limited time to complete the game) or before the game?

@robske110 robske110 changed the title add on gameEnd function Implement teleportation onGameEnd Mar 31, 2018
@robske110 robske110 added this to the 1.0.0 milestone Mar 31, 2018
@robske110
Copy link
Owner

TODO: Configureable on-game-end teleportation to a specified level's spawn location or to a specified level, x, y z.

@ghost
Copy link
Author

ghost commented Mar 31, 2018

the players inventory doesn't get cleared when the game ends , it only clears it upon a new game start and yes the countdown is during the game

@ghost
Copy link
Author

ghost commented Mar 31, 2018

and also add an announce for the winner to all players + a money reward for the winner (dependency: EconomyAPI)

@ghost
Copy link
Author

ghost commented Mar 31, 2018

this is a very very awesome plugin i really like it and thats why i want it to be better and see it on all servers in the future, i admire this mind and this type of thinking u have .

[off-topic]
if it's not much on u i want u to see if u can update the colormatch plugin which can be found on youtube in ur spare time , it was such a great game but unfortunately it can't be used now .

@robske110
Copy link
Owner

robske110 commented Mar 31, 2018

Moved all seperate suggestions to #11 #10 #8
And for the offtopic thing: A link would be helpful!

@ghost
Copy link
Author

ghost commented Mar 31, 2018

@ghost
Copy link
Author

ghost commented Mar 31, 2018

but first make the priority for the gameEnd teleportation cuz my server is about to be opened and this is the only issue left

@ghost
Copy link
Author

ghost commented Apr 4, 2018

@robske110 can you please hurry up with the teleportation request I've been refreshing this page for the past 5 days waiting for a reply saying its done , i know you are busy but please try to finish this one for me , thank you.

@robske110
Copy link
Owner

image

working on it...

@robske110
Copy link
Owner

I pushed the brach 1.0.0-InDev which has the current WIP on it. Its is untested since the game is broken on 1.2.13 (probably ItemFrame Interaction broken in PM, will check tomorrow)

@ghost
Copy link
Author

ghost commented Apr 5, 2018

putting it to support only 1.2.10 for now will be much easier, then at some other time update the whole plugin to work on 1.2.13

@robske110
Copy link
Owner

Actually, the game wasn't broken at all, I was just too dumb to create an Arena for testing. (lol)
Current work is done here: https://github.com/robske110/TicTacToe/tree/1.0.0-InDev
If you need the feature now, you can use 1.0.0-InDev-alpha-pre (Yes, very unstable untested and alpha-y).
I recommend to not use the delayed-teleport feature right now, it has some problems...

@ghost ghost closed this as completed Aug 28, 2019
@robske110
Copy link
Owner

I‘ll keep this open since it is not implemented on master yet.

@robske110 robske110 reopened this Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant