Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Examples need porting for 2025 Revlib #73

Open
sciencewhiz opened this issue Jan 22, 2025 · 3 comments
Open

[BUG]: Examples need porting for 2025 Revlib #73

sciencewhiz opened this issue Jan 22, 2025 · 3 comments
Labels
good first issue Good for newcomers

Comments

@sciencewhiz
Copy link
Contributor

sciencewhiz commented Jan 22, 2025 •
edited
Loading

Problem description

It looks like none of the robotpy-rev examples have been ported for 2025. For example, they use CANSparkMax instead of SparkMax. https://docs.revrobotics.com/brushless/revlib/revlib-overview/migrating-to-revlib-2025

https://www.chiefdelphi.com/t/coding-for-rev-robotics-swerve-drive-using-robotpy/482757/3
@virtuald
Copy link
Member

Yeah, we probably should run tests on the examples in CI to catch things like this.

@auscompgeek auscompgeek added the good first issue Good for newcomers label Jan 22, 2025
@virtuald
Copy link
Member

Fixed in #74

@sciencewhiz
Copy link
Contributor Author

can-arcade-drive, can-tank-drive, getting-started, and limit-switch were done in #74.

The following still need to be done:

  • color_match
  • maxswerve
  • position-pid-control
  • read_rgb_values
  • read-encoder-values
  • smart-motion
  • velocity-pid-control

@virtuald virtuald reopened this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
2025 Season
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@auscompgeek @virtuald @sciencewhiz