-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert the repo into the robotology superbuild #131
Comments
CC @traversaro |
See the docs in https://github.com/robotology/robotology-superbuild/blob/master/doc/developers-faqs.md#how-to-add-a-new-package . As we plan to add the package in conda-forge, notice that we need to let know that to the robotology-superbuild by setting the |
According to https://github.com/robotology/robotology-superbuild/blob/master/doc/cmake-options.md#profile-specific-documentation, should gz-sim-yarp-plugins be part of the profile Moreover, if I recall well, we should check that the options |
Yes.
Yes, I remember mentioning this, but perhaps this is not strictly necessary in the long term. We can document how install a gz-sim compatible build of gazebo (on apt) and build a gz-sim compaible build of gazebo-classic in conda-forge (for conda). Anyhow, we can probably leave this aside for the first PR. |
Where I should put the dependencies of the package? The In general what other files should I modify other than the Buildgz-sim-yarp-plugins.cmake? |
Yes. Other dependencies go in the documentation and in the ci script (unfortunately duplicated).
I would say:
|
In order to test if I made all the necessary updates, is it sufficient to check the CI is passing or should I try some of the methods in which the robotology can be installed? |
I guess CI is enough, as long as you check that CI actually enables the option you want to test. |
To avoid the mutual exclusivity between gazebo-classic and gz-sim8, we can use the following changes:
|
robotology/robotology-superbuild#1628 has been merged. Closing! |
Robotology superbuild: https://github.com/robotology/robotology-superbuild
PR: robotology/robotology-superbuild#1628
The text was updated successfully, but these errors were encountered: