Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert the repo into the robotology superbuild #131

Closed
xela-95 opened this issue Mar 21, 2024 · 10 comments
Closed

Insert the repo into the robotology superbuild #131

xela-95 opened this issue Mar 21, 2024 · 10 comments
Assignees

Comments

@xela-95
Copy link
Member

xela-95 commented Mar 21, 2024

Robotology superbuild: https://github.com/robotology/robotology-superbuild

PR: robotology/robotology-superbuild#1628

@xela-95
Copy link
Member Author

xela-95 commented Mar 21, 2024

CC @traversaro

@traversaro
Copy link
Member

See the docs in https://github.com/robotology/robotology-superbuild/blob/master/doc/developers-faqs.md#how-to-add-a-new-package . As we plan to add the package in conda-forge, notice that we need to let know that to the robotology-superbuild by setting the gz-sim-yarp-plugins_CONDA_PKG_CONDA_FORGE_OVERRIDE option, see https://github.com/robotology/robotology-superbuild/blob/master/doc/developers-faqs.md#how-to-ensure-that-binary-packages-are-correctly-generated-for-a-new-package . This is useful to ensure that no gz-sim-yarp-plugins package is added in the robotology conda channel.

@xela-95
Copy link
Member Author

xela-95 commented Mar 29, 2024

According to https://github.com/robotology/robotology-superbuild/blob/master/doc/cmake-options.md#profile-specific-documentation, should gz-sim-yarp-plugins be part of the profile CORE and have a custom CMake dependency option like ROBOTOLOGY_USES_GZ_SIM?

Moreover, if I recall well, we should check that the options ROBOTOLOGY_USES_GAZEBO and ROBOTOLOGY_USES_GZ_SIM are mutually exclusive, otherwise log a an error.

@traversaro
Copy link
Member

According to https://github.com/robotology/robotology-superbuild/blob/master/doc/cmake-options.md#profile-specific-documentation, should gz-sim-yarp-plugins be part of the profile CORE and have a custom CMake dependency option like ROBOTOLOGY_USES_GZ_SIM?

Yes.

Moreover, if I recall well, we should check that the options ROBOTOLOGY_USES_GAZEBO and ROBOTOLOGY_USES_GZ_SIM are mutually exclusive, otherwise log a an error.

Yes, I remember mentioning this, but perhaps this is not strictly necessary in the long term. We can document how install a gz-sim compatible build of gazebo (on apt) and build a gz-sim compaible build of gazebo-classic in conda-forge (for conda). Anyhow, we can probably leave this aside for the first PR.

@xela-95
Copy link
Member Author

xela-95 commented Mar 29, 2024

Where I should put the dependencies of the package? The DEPENDS field of ycm_ep_helper is only for packages inside the superbuild? https://github.com/xela-95/robotology-superbuild/blob/056c18b2c0ca5e953705870b278463bdd1415eb2/cmake/Buildgz-sim-yarp-plugins.cmake#L15-L16

In general what other files should I modify other than the Buildgz-sim-yarp-plugins.cmake?

@traversaro
Copy link
Member

Where I should put the dependencies of the package? The DEPENDS field of ycm_ep_helper is only for packages inside the superbuild? https://github.com/xela-95/robotology-superbuild/blob/056c18b2c0ca5e953705870b278463bdd1415eb2/cmake/Buildgz-sim-yarp-plugins.cmake#L15-L16

Yes. Other dependencies go in the documentation and in the ci script (unfortunately duplicated).

In general what other files should I modify other than the Buildgz-sim-yarp-plugins.cmake?

I would say:

@xela-95
Copy link
Member Author

xela-95 commented Mar 31, 2024

In order to test if I made all the necessary updates, is it sufficient to check the CI is passing or should I try some of the methods in which the robotology can be installed?

@traversaro
Copy link
Member

In order to test if I made all the necessary updates, is it sufficient to check the CI is passing or should I try some of the methods in which the robotology can be installed?

I guess CI is enough, as long as you check that CI actually enables the option you want to test.

@traversaro
Copy link
Member

To avoid the mutual exclusivity between gazebo-classic and gz-sim8, we can use the following changes:

@xela-95
Copy link
Member Author

xela-95 commented Apr 5, 2024

robotology/robotology-superbuild#1628 has been merged. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants