Is it a written mistake in Line 45 in bundle.py？

[zhchyang2004]

Hi, whether the correct formular should be 'f = width/2 / tan(radians(fovh)/2)' instead of the current one on Line 45?

[zbynekwinkler]

Just to have a reference, we are talking about this code:

simple-sfm/bundle.py

Lines 42 to 50 in 6f3a462

	def cam2mat(camera):
	# http://docs.opencv.org/trunk/d9/d0c/group__calib3d.html#details
	fovh, width, height = camera
	f = width/2 * tan(radians(fovh)/2)
	cx, cy = width/2, height/2
	return np.array(
	((f, 0, cx),
	(0, f, cy),
	(0, 0, 1)))

where f is the calculated focal distance in pixels using horizontal field of view and pixel width and height.

The focal length should be increasing with the FOV decreasing. You are right, thanks 👍. Too bad I never got to finish this.