Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FtpSslSessionReuseException #1224

Closed
robinrodricks opened this issue Mar 1, 2023 · 6 comments
Closed

New FtpSslSessionReuseException #1224

robinrodricks opened this issue Mar 1, 2023 · 6 comments

Comments

@robinrodricks
Copy link
Owner

robinrodricks commented Mar 1, 2023

@FanDjango what is your thought on absorbing errors like this and instead throwing a special exception with the exact advise you give out on the forums?

SSL connection failed; session reuse required -> FtpSslSessionReuseException which then has the message "You need to 1) upgrade your FTP server to the latest or 2) disable SSL session reuse in your FTP server or 3) use FluentFTP.GnuTLS which supports SSL session reuse"

It should reduce the workload of constantly answering the same damn thing when it comes up as a bug ticket.

What say? Is it possible? Is it viable?

@robinrodricks robinrodricks changed the title SSL connection failed; session reuse required New FtpSslSessionReuseException Mar 1, 2023
@FanDjango
Copy link
Collaborator

excellent idea.

I sometimes prefer one or two lines of "ERROR" messages prior to a normal exception.

Also: Not every failure to authenticate the 2nd, 3rd, 4th, etc. connection (i.e. the data connection) is due to session resume problems, although we currently seem to be getting only these errors.

But by all means…

@FanDjango
Copy link
Collaborator

if (connection == data_connection)...
 {message with advice
 throw (possible resume failure exception)
}

@FanDjango
Copy link
Collaborator

Some more thoughts on this:

Quite a few cases exist where the SSL Authentication itself does not fail, but shortly after, there is a "4xx" message saying that it was not possible to open a data connection.

"Operation not permitted" is one such message, another actually refers to "session resume". There is a whole catalog of such messages, depending on the server type.

@4nd3r5
Copy link

4nd3r5 commented Mar 17, 2023

Is there a tracked issue in .net regarding this, we can subscribe to?

@FanDjango
Copy link
Collaborator

@4nd3r5 You might want to read through this issue

#948 (comment)

@FanDjango
Copy link
Collaborator

FanDjango commented Mar 21, 2023

I have moved this to the Wiki: https://github.com/robinrodricks/FluentFTP/wiki/Future-Plans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants