Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting gemJars does not work as expected #29

Open
fcarter opened this issue Oct 9, 2014 · 0 comments
Open

setting gemJars does not work as expected #29

fcarter opened this issue Oct 9, 2014 · 0 comments

Comments

@fcarter
Copy link

fcarter commented Oct 9, 2014

Assumption: setting gemJars in the compass configuration should use the provided jar(s) to obtain the Ruby gems rather that fetching over the network. This is important in some environments due to network
access & proxy topology issues.

In 1.0.10, setting gemJars has no apparent affect.

Looking into things, in DependenciesResolver.groovy, the check is made for "if (gemJars?.empty)..". I believe that "empty" is not a valid property here, but due to groovy's forgiving nature, the test is allowed (I suspect it's treating things like a map & looking for a key named empty).

I made a local fix by changing the test to "if (gemJars?.isEmpty())...", wherein things seemed to work as (I) expected.

I would upload the fix, but running the tests seems to generate a number of (seemingly unrelated) MIssingMethodExceptions (ImageGenerationSpec.groovy:24, :37, :50, :63 -- apparently about project.runTasks). I may be using an older groovy, gradle, or something. At any rate, without getting a successful build, I'm hesitant to push a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant