-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add travis icon #195
add travis icon #195
Conversation
pulling the latest branch
@jens1o change the supported extensions file addition to:
|
done, thanks for the heads up |
What does the "special" do? |
Let's say you have a file with a .js extension but you want it to have the flash icon (weird but you never know...) then using a special attribute you're saying: this is a js file but if it has the following structure (extension attribute) then assign the "icon attribute" |
In the current case, we're saying, ok this is a yml file (special) but if it has the following form (travis.yml) don't assign .yml icon to it but instead use the travis icon. |
Ahhh, now it's clear. Could you add it to the CONTRIBUTION.md file? |
I'll create a link to these thread in the Readme. ref #201 |
My plugin has updated (to version 1.8.3), but the icon does not apear for my file. I think that, maybe, this line: Font: https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI%3A
I have tried to create a 'travis.yml' file, to see if the icon apears correctly, but no success.. @jens1o I am doing something wrong ? |
@AlexandreSNeto It should be working even without the dot so definitely you're missing something. |
Update: _Example:_ Advise: |
_Fixes #185_
Changes proposed:
Things I've done:
npm install
to install all the dependeniesnpm run build
to build the extension. (If I had done something with the extension.)adds .travis.yml