Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add travis icon #195

Merged
merged 8 commits into from
Aug 27, 2016
Merged

add travis icon #195

merged 8 commits into from
Aug 27, 2016

Conversation

jens1o
Copy link
Member

@jens1o jens1o commented Aug 27, 2016

_Fixes #185_

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • I've pulled the latest master branch
  • I've run npm install to install all the dependenies
  • I've checked my code, it is clean.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • My pull request is not too big, otherwise I've already squashed it.
  • I've run npm run build to build the extension. (If I had done something with the extension.)

adds .travis.yml

@robertohuertasm
Copy link
Member

@jens1o change the supported extensions file addition to:

{ icon: 'travis', extensions: ['travis.yml'], special: 'yml' },

@jens1o
Copy link
Member Author

jens1o commented Aug 27, 2016

done, thanks for the heads up

@robertohuertasm robertohuertasm merged commit 417c87f into vscode-icons:master Aug 27, 2016
@Gama11
Copy link
Contributor

Gama11 commented Aug 27, 2016

What does the "special" do?

@jens1o jens1o deleted the jens1o-travis branch August 27, 2016 16:06
@robertohuertasm
Copy link
Member

Let's say you have a file with a .js extension but you want it to have the flash icon (weird but you never know...) then using a special attribute you're saying: this is a js file but if it has the following structure (extension attribute) then assign the "icon attribute"

@robertohuertasm
Copy link
Member

In the current case, we're saying, ok this is a yml file (special) but if it has the following form (travis.yml) don't assign .yml icon to it but instead use the travis icon.

@jens1o
Copy link
Member Author

jens1o commented Aug 27, 2016

Ahhh, now it's clear. Could you add it to the CONTRIBUTION.md file?

@robertohuertasm
Copy link
Member

I'll create a link to these thread in the Readme. ref #201

@AlexandreSNeto
Copy link

My plugin has updated (to version 1.8.3), but the icon does not apear for my file.

I think that, maybe, this line:
{ icon: 'travis', extensions: ['travis.yml'], special: 'yml' },
should be:
{ icon: 'travis', extensions: ['.travis.yml'], special: 'yml' },

Font: https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI%3A

Add a .travis.yml file to your repository to tell Travis CI what to build:

I have tried to create a 'travis.yml' file, to see if the icon apears correctly, but no success..

@jens1o I am doing something wrong ?

@Gama11
Copy link
Contributor

Gama11 commented Aug 29, 2016

I have tried to create a 'travis.yml' file

Travis files start with a dot .travis.yml. For me it works:

Have you started VSCode with admin rights so vscode-icons can install itself?

@robertohuertasm
Copy link
Member

@AlexandreSNeto It should be working even without the dot so definitely you're missing something.

@JimiC
Copy link
Member

JimiC commented Nov 6, 2016

Update:
special has been replaced with contribType.

_Example:_
{ icon: 'travis', extensions: ['.travis.yml'], special: 'yml' }
becomes
{ icon: 'travis', extensions: ['.travis.yml'], contribType: ctype.filename }

Advise:
When you make any change to the supportedExtensions.js or supportedFolders.js, after you run the build command, if you are overwriting the existing installation of this extension in vscode, make sure to copy also the icons.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants