Note text encryption #231
Open
Note text encryption #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert7
reviewed
Nov 12, 2024
| //----< convert vector of bytes to std::string >--------------------- | ||
|
|
||
| std::string Base64::encode(const std::vector<char>& data) | ||
| { |
There was a problem hiding this comment.
Why code (body of functions) is in a header file?
Repository owner
deleted a comment from
rspiegel-nc
Nov 12, 2024
robert7
reviewed
Nov 12, 2024
| @@ -34,6 +35,9 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |||
| #include "src/communication/communicationmanager.h" | |||
| #include "src/communication/communicationerror.h" | |||
| #include "src/sql/nsqlquery.h" | |||
| #include "encrypt.h" | |||
|
|
|||
| #define CRYPT_KEY "6aabbb3efbd1ff6d606061684e9749cd476763a8" | |||
There was a problem hiding this comment.
The encryption key should never be checked in the version control. This defeats the whole purpose of encryption. Even if the code were not public, it still would only be an obfuscation.
robert7
reviewed
Nov 12, 2024
|
|
||
| // encrypt | ||
|
|
||
| std::string encrypt(std::string& msg, std::string& key) |
There was a problem hiding this comment.
Why not use some built-in strong encryption algorithm? "Home made cryptography" is discouraged. Please use some vetted stable library to do encryption and decryption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the "{{encrypt}}" tag to the note text can automatically encrypt and decrypt the note text when syncing to Evernote. The purpose is to only want to sync between two NixNotes, and do not want the plain text to appear in the Evernote cloud.