Comment out the tedious resource synchronization code. #223
Conversation
|
Hi @boo-yee, |
|
Sorry but I have not completed yet, maybe have to work for more time. :( |
as the resouces has been included in the notes.
|
I updated the post, adding some details, and I think this pr is ready for reviewing now. |
boo-yee
changed the title
boo-yee
changed the title
|
Hi, Unfortunately Travis build doesn't work now, as my free account expired, but I already wrote to Travis, hopefully they resume my account. |
|
That's all right. We can still do it by ourselves by hand. Thanks for your work. |
|
There is a parameter of getNote function called withResource. If it is set to true, the api caller will download the reource along with the note. that is why I think the commented out code is tedious. |
|
It seems that the Travis CI works now and the latest AppImage has been built. Thanks again. |
|
Travis account is renewed and should work until end of 2024 (then it would need another renew) |
Hi, Robert. The rate limit excpetion was often talked about earlier. Maybe we can have an improvement now.
I found that Nixnote sychronizes the resources twice, when syncing the notes, the resources are synced together in fact, but it seems that Nixnote syncs the resources one by one later, and I think this is the reason that the exception often appears. So I commented out the standalone resources sychronization code. I commented out instead of deleting them, because I am afraid that there are some side effects. I have tested with an account which has only a few notes and resources, and the notes can be synchronized normally, but I am not totally sure if the exception occurs when there are a large amount of notes.
It cannot walk around the limit totally, but it should possibly low down its occurrence. My trouble now is that I find it takes too much time to upload my faked large sized note content, so I hope someone who has a large amount of notes can help on it, if there is any. So please use the travis CI to build a binary file if possible for the convenience of testing. Thank you first.
For solving this issue, I referred to the code of evernote-back(an open source project too, for backuping up notes, rate limit excepton lessly happens on it), and found it syncs the note along with the resources, no standalone synchronization for the resources. That is to say, if there are 1k notes, each note contains two images, then Nixnote previously needed to make (a few more than)1k+2k api callings. If we sync the notes together with the resources, it will be only (a few more than)1k. Based on this estimation, I think we can reduce the rate limit exceptons.
I keep the changelog unchanged for now. I'll update it as soon as the testing is finished.