Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The icon on invited users is displaying incorrectly #60

Closed
robby1066 opened this issue Jun 15, 2021 · 1 comment
Closed

The icon on invited users is displaying incorrectly #60

robby1066 opened this issue Jun 15, 2021 · 1 comment
Labels
bug Something isn't working message creation Items that relate to the creation and recording of messages user management Items that relate to the management of users in Keep Posted
Milestone

Comments

@robby1066
Copy link
Owner

Describe the bug

When inviting a new user to participate in a roundtable message, the icon (which shows the first letter of the person's first name) in the select list is rendered poorly. It should be a round icon, and there should be some margin between the icon and the name. As it displays now, it just looks like the first letter of the person's first name is repeated twice, and the first one is in another color with a halo around it.

Steps To Reproduce

  1. Go to /messages/roundtable
  2. Click on select specific people -> invite someone new
  3. Invite a test user
  4. See how the invited user's name displays in the select list.

Expected behavior

The icon shouldn't actually display at all, if it is to be consistent with how existing names in that list are displayed.

Screenshots

Screenshot 2021-06-15 at 13 51 17

@robby1066 robby1066 added this to the For June milestone Jun 15, 2021
@robby1066 robby1066 added bug Something isn't working message creation Items that relate to the creation and recording of messages user management Items that relate to the management of users in Keep Posted labels Jun 23, 2021
@robby1066
Copy link
Owner Author

Fixed and tested locally. The problem was that those entries can be constructed in two places, and the generated markup wasn't consistent. It was just a matter of removing the icon.

Will go out in the next deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working message creation Items that relate to the creation and recording of messages user management Items that relate to the management of users in Keep Posted
Projects
None yet
Development

No branches or pull requests

1 participant