Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sharing options by allowing copying of rich-text links #6

Closed
robby1066 opened this issue Dec 8, 2020 · 9 comments
Closed
Labels
enhancement New feature or request message sharing Items that relate to the sharing of messages in other systems
Milestone

Comments

@robby1066
Copy link
Owner

Area affected

Sharing completed messages

What's the problem

It's cumbersome to share a link to a message in an email or other system if the presentation of that link is anything other than just the plain URL. A clickable thumbnail would be more attractive. Sometimes it's desireable to use an HTML link instead of a plain url.

Description of feature

The sharing section on the completed message page will be updated to include more options for copy / paste

Alternatives and workarounds

Currently, the user can copy the url and use another system to create a text link (Example: select text then cmd+k in Gmail) . A thumbnail can be created by taking a screenshot of the video in the player.

Additional context

Implementing this feature correctly might include also generating a dedicated title image for each message rather than using the first clip title image.

@robby1066 robby1066 added the enhancement New feature or request label Dec 8, 2020
@robby1066 robby1066 added this to the For February milestone Jan 22, 2021
@robby1066 robby1066 added the message sharing Items that relate to the sharing of messages in other systems label Feb 1, 2021
@robby1066
Copy link
Owner Author

Example of the current share options.
image

@robby1066
Copy link
Owner Author

robby1066 commented Feb 23, 2021

Sharing the comment above will likely lead to something like this:

Hey everyone! Here's an update I recorded using Keep Posted: https://robby.keepposted.io/msg/117-eb160de1de89d9058fcb0b968dbbbd68

Example of what a rich text snippet could look like:

Robby shared a message—Using Closed Captions In Keep Posted Messages

@robby1066
Copy link
Owner Author

Providing a preview is hampered somewhat by the fact that messages don't have dedicated title images. Generally, the first image of the first clip has been the defacto message image, but there are some cases where that's not ideal. For example, a roundtable message where 5 people answer the same question "What are you working on" would look like the message was titled "First name: What are you working on?" where "First Name" is whoever happened to have recorded the first clip.

@robby1066 robby1066 added the working on it This issue is actively being worked on label Feb 24, 2021
@robby1066
Copy link
Owner Author

Laying the groundwork for this and #26 I'm reworking the design of the sharing elements. Here's a first pass that feels like progress.

Sharing UI Comparison

@robby1066
Copy link
Owner Author

Clickable prototype

@robby1066
Copy link
Owner Author

Working code comparison of the two blocks:
image

@robby1066
Copy link
Owner Author

robby1066 commented Feb 26, 2021

Deployed to production on Feb 25.

Invitation copy/paste works pretty well in multiple contexts

In Gmail (which supports full rich text pasting):
image

In Slack (for illustration purposes - supports rich text except for images):
image

In Signal (which doesn't support rich text pasting at all):
image

@robby1066
Copy link
Owner Author

Deployed and updated the documentation

@robby1066 robby1066 removed the working on it This issue is actively being worked on label Feb 26, 2021
@robby1066
Copy link
Owner Author

Screenshot.2021-03-01.at.15.51.13.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request message sharing Items that relate to the sharing of messages in other systems
Projects
None yet
Development

No branches or pull requests

1 participant