Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'detailed feedback' on message display on mobile is missing and a green block is displayed instead #51

Closed
robby1066 opened this issue Mar 5, 2021 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@robby1066
Copy link
Owner

Describe the bug

At the end of a message, there is supposed to be an option for structured feedback, and detailed, free text feedback.

On mobile, only the structured feedback is shown and beneath it is a green block where the detailed feedback section should be.

Steps To Reproduce

  1. Go to a message on mobile. example
  2. Watch the video (or skip to the end until the replay or feedback options appear)
  3. Scroll past the structured feedback section
  4. Observe that the detailed feedback section is missing and there is a green block in it's place.

Expected behavior

The viewer should be able to access the detailed feedback block

Screenshots

Screenshot 2021-03-05 at 16 29 40

@robby1066
Copy link
Owner Author

This may be related to #30 and how the detailed feedback section is hidden from the tab order.

@robby1066 robby1066 added this to the For March milestone Mar 5, 2021
@robby1066 robby1066 added the bug Something isn't working label Mar 11, 2021
@robby1066
Copy link
Owner Author

This is fixed and ready for deploy. The change effectively removes the special visibility: hidden tweaks to manage the focus order, but only on mobile. I'm unsure of the accessibility fallout of that. Since the elements that were getting hidden should actually be visible at all times in the mobile view, this shouldn't have a negative impact on the focus order. But there may be some use cases I'm not thinking about.

@robby1066
Copy link
Owner Author

In testing, I realized this fix somehow hides the 'go faster' button on mobile. Not sure why that is. But this issue can't be closed until that's fixed.

@robby1066
Copy link
Owner Author

Found the problem. The accessibility visibility rules in the CSS file were right next to the rule that managed the visibility of the "go faster" button. I overzealously copy / pasted when I moved the accessibility stuff to the desktop only section 🤦‍♂️.

Fixed and will go out in the next deploy.

@robby1066
Copy link
Owner Author

All bugs are fixed and tested. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant