Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow captions to be uploaded in .srt format #46

Closed
robby1066 opened this issue Mar 2, 2021 · 3 comments
Closed

Allow captions to be uploaded in .srt format #46

robby1066 opened this issue Mar 2, 2021 · 3 comments
Labels
accessibility Improve accessibility of something enhancement New feature or request message creation Items that relate to the creation and recording of messages
Milestone
For March

Comments

@robby1066
Copy link
Owner

What's the problem you're hoping this new feature will solve?

The current closed-captions process relies on using another service to generate the captions. There are many services that don't offer .vtt file exports, but they do offer .srt exports, which can be converted into .vtt files.

Description of feature

People adding captions would be able to upload either a .vtt file or an .srt file. When the server receives a .srt file, it would convert it to .vtt for use when the video is played.

Alternatives and workarounds

Currently, if a person generating captions uses a tool that only exports in .srt, they would have to handle the conversion to .vtt themselves before uploading, which is offloading a lot of work on the user.
@robby1066 robby1066 added enhancement New feature or request accessibility Improve accessibility of something labels Mar 2, 2021
@robby1066
Copy link
Owner Author

The webvtt-ruby gem looks like it could handle the conversion pretty well.

@robby1066 robby1066 added this to the For March milestone Mar 2, 2021
@robby1066 robby1066 added the message creation Items that relate to the creation and recording of messages label Mar 2, 2021
@robby1066
Copy link
Owner Author

Added .srt support. The .srt file is inspected before it is validated and converted if it exists.

Also updated the text on the manage closed captions modal to make it clear that both types are supported.

Screenshot 2021-03-26 at 18 27 24

Documentation needs to be updated. Otherwise this can be closed.

@robby1066 robby1066 added the working on it This issue is actively being worked on label Mar 26, 2021
@robby1066
Copy link
Owner Author

Deployed and tested in production. The documentation has been updated. Closing this issue.

@robby1066 robby1066 removed the working on it This issue is actively being worked on label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Improve accessibility of something enhancement New feature or request message creation Items that relate to the creation and recording of messages
Projects
None yet
Milestone
For March
Development

No branches or pull requests
1 participant
@robby1066