Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message preview pages have incorrect open graph tags #38

Closed
robby1066 opened this issue Feb 21, 2021 · 3 comments
Closed

Message preview pages have incorrect open graph tags #38

robby1066 opened this issue Feb 21, 2021 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@robby1066
Copy link
Owner

Describe the bug

The preview page (which can be shared ahead of the message being finalized) uses the same layout as the message display, including the open graph tags in the header. There is a lot of specific language in those tags that implies the message is complete. This can be confusing to people who are getting the link shared in any system that unfurls and shows a rich preview (Slack, Signal, or Teams, for example)

Steps To Reproduce

  1. Go to a message detail page (currently only exposed for roundtable messages, which haven't been officially released as of 2/20)
  2. View source (or paste the link into Slack)
  3. Observe the Open graph tags

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

image

Additional context

Aside from clearing up confusion, there is an opportunity to use the open graph info to clarify the purpose of the preview page, which may be people's first experience with Keep Posted.

@robby1066 robby1066 added the bug Something isn't working label Feb 21, 2021
@robby1066
Copy link
Owner Author

As a first step I just removed the open graph tags from the message preview (they were throwing an exception under certain circumstances, so removing them was just a way to fix that)

It feels more correct to provide alternative open graph tags to provide a preview of what people can expect when clicking the link.

One off-the-cuff possibility:

  • og:title: "creator.first_name wants to hear from the team"
  • og:url: message.preview_url
  • og:image: Not sure what (if anything) would be useful here? We may or may not have a title image generated, and it may or may not include confusing information, like someone else's name.
  • og:type: "website"
  • og:description: message.subject (e.g. "What are you working on today?")

@robby1066 robby1066 added this to the For February milestone Feb 23, 2021
@robby1066
Copy link
Owner Author

After some testing, it seems like it's worth it to include something for the og:image tag. Otherwise some places dig up an image from elsewhere in the source, leading to some unpredictable previews.

Probably best in this case to create a generic placeholder image for the message type that can be used.

@robby1066
Copy link
Owner Author

Added a placeholder that feels appropriate for in-progress messages.

Open Graph Info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant