Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using keyboard navigation, focus gets stuck in the edit message title field #28

Closed
robby1066 opened this issue Feb 1, 2021 · 2 comments
Labels
accessibility Improve accessibility of something bug Something isn't working
Milestone

Comments

@robby1066
Copy link
Owner

Describe the bug

When navigating the page via keyboard only navigation, once the keyboard focus is placed on the "edit title" inline form element, it cannot be moved away unless the form is opened, and then the cancel button is activated.

Steps To Reproduce

  1. Go to a message display page /messages/SOME_MESSAGE_ID on a browser that supports keyboard navigation
  2. Tab through until the message title is highlighted
  3. Attempt to tab away (either by pressing tab more or shift+tab to go back in the tab order)
  4. See that the focus never leaves the message title

Expected behavior

A person using keyboard navigation should be able to tab through all the elements without getting stuck.

@robby1066 robby1066 added bug Something isn't working accessibility Improve accessibility of something labels Feb 1, 2021
@robby1066 robby1066 added this to the For February milestone Feb 4, 2021
@robby1066
Copy link
Owner Author

Looks like this is due to an event handler in the javascript that handles editing the message title. It was (seemingly) erroneously not letting key events fall through to their default behavior.

@robby1066
Copy link
Owner Author

Example of updating a message title using just keyboard navigation.

edit-message-title-keyboard.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improve accessibility of something bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant