Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Assistant Custom Component Councils List #326

Closed
OliverCullimore opened this issue Sep 15, 2023 · 1 comment
Closed

Home Assistant Custom Component Councils List #326

OliverCullimore opened this issue Sep 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@OliverCullimore
Copy link
Collaborator

May need to review config_flow.py line 23 at some point once merged.

It currently uses "https://raw.githubusercontent.com/robbrad/UKBinCollectionData/master/uk_bin_collection/tests/input.json" to get the list of supported councils however this may not match the locally installed Python bin collection library's supported councils list.

To resolve this it might be that we need to bundle this file as part of the Python library build process and add a function that returns this list to the Python library for us to call from the custom component.

@OliverCullimore
Copy link
Collaborator Author

Looks like #348 and #349 should've done the trick to implement this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant