Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leeds council performace #141

Closed
robbrad opened this issue Dec 21, 2022 · 6 comments
Closed

Leeds council performace #141

robbrad opened this issue Dec 21, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@robbrad
Copy link
Owner

robbrad commented Dec 21, 2022

Seaons greetings @dp247 - the Leeds council takes a long time to run - downloading the address file etc each time.

Any thoughts on how to remove the need to do this?

What if it was a pre-req to find out your UPRN before run? - or do these change?

@robbrad robbrad added the enhancement New feature or request label Dec 21, 2022
@dp247
Copy link
Collaborator

dp247 commented Dec 21, 2022

I like how github didn't send me an email for that ping 😅.

It could def be changed to eliminate one of the CSVs by asking users to find their property id in the dataset. I'll have a play around.

@dp247
Copy link
Collaborator

dp247 commented Dec 23, 2022

Wrote a tool that can parse the premises.csv file with an inputted postcode and paon/saon and return the correct premises ID for a property:
image

So the scraper can be updated to take the ID as UPRN and reduce the load time. I haven't written any docs yet, but the script is here (lots more user-friendly than downloading the CSV file and finding the ID manually I reckon!)

@dp247 dp247 mentioned this issue Jan 6, 2023
@robbrad
Copy link
Owner Author

robbrad commented Oct 30, 2023

@dp247 when you get a second - can you check the current performace on the Leeds council - I think we are in a good place on this now?

@robbrad
Copy link
Owner Author

robbrad commented Nov 2, 2023

@dp247 - im gonna close for now

@dp247
Copy link
Collaborator

dp247 commented Nov 28, 2023

@dp247 - im gonna close for now

Didn't actually see this until today, but yeah, its working much quicker than I remember. It will probably never be massively speedy because the job file it parses is ~139MB lol

@robbrad robbrad reopened this Dec 16, 2023
@robbrad
Copy link
Owner Author

robbrad commented Dec 16, 2023

I think making this Selenium would make a big difference

https://www.leeds.gov.uk/residents/bins-and-recycling/check-your-bin-day

@robbrad robbrad self-assigned this Dec 16, 2023
@dp247 dp247 closed this as completed in 56742da Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants