Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is braking supported? #1

Open
poorboy44 opened this issue Dec 4, 2018 · 1 comment
Open

Is braking supported? #1

poorboy44 opened this issue Dec 4, 2018 · 1 comment

Comments

@poorboy44
Copy link

I'm trying to figure out if braking is supported. I would like the default behavior ("no signal") to be full brake. This is for safety in case my robot is on a hill, etc. However, looking at the morph_hw code I am not seeing any braking member functions. Do you know if braking is currently supported, or I need to implement it?

@roaldlemmens
Copy link
Owner

Currently there's no braking implementation. In morph_hw.cpp there's a check if there's a velocity set (if (_cmd[0] != 0.0)), in the else of the check the motor is release ( _left_wheel_driver.releaseMotor();). This has the benefit of being able to manually move the robot and save battery. Ideally a safetycontroller would be implemented which would use the VESC braking when needed. For instance combined with IMU data. Another option would be to implement braking instead of releasing by default when requested speed is 0. It would be nice if this could be configured (using ros dynamic reconfigure) to change the behaviour, for instance when you want to release the motors to move the robot manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants