Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

feature: allow using []string command instead of string #85

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

rustatian
Copy link
Member

Reason for This PR

ref: roadrunner-server/roadrunner#1667

Description of Changes

  • Handle []string command case, when user can send raw command and avoid parsing by RR.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added beta-nominated Nominated for backporting to the RR in the beta channel. C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Aug 7, 2023
@rustatian rustatian requested a review from wolfy-j August 7, 2023 22:42
@rustatian rustatian self-assigned this Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #85 (8062c2a) into master (16ad626) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   79.50%   79.47%   -0.03%     
==========================================
  Files          23       23              
  Lines        2000     2002       +2     
==========================================
+ Hits         1590     1591       +1     
- Misses        359      360       +1     
  Partials       51       51              
Files Changed Coverage Δ
pool/config.go 100.00% <ø> (ø)
fsm/fsm.go 68.29% <50.00%> (-0.46%) ⬇️
pool/allocator.go 87.50% <100.00%> (ø)

@rustatian rustatian merged commit c1d5303 into master Aug 7, 2023
@rustatian rustatian deleted the feature/allow-custom-command branch August 7, 2023 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beta-nominated Nominated for backporting to the RR in the beta channel. C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Unreleased
Development

Successfully merging this pull request may close these issues.

1 participant