Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

feat(pool options): add ability to use custom error encoder #6

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

rustatian
Copy link
Member

Reason for This PR

  • Custom error handler for the static pool.

Description of Changes

  • Add pool option to override the default error encoder
  • Add tests

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added A-other Area: other C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Feb 9, 2022
@rustatian rustatian requested a review from wolfy-j February 9, 2022 18:46
@rustatian rustatian self-assigned this Feb 9, 2022
Signed-off-by: Valery Piashchynski <[email protected]>
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #6 (e636f37) into master (b23c7a6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   79.71%   79.75%   +0.03%     
==========================================
  Files          19       20       +1     
  Lines        1711     1714       +3     
==========================================
+ Hits         1364     1367       +3     
  Misses        293      293              
  Partials       54       54              
Impacted Files Coverage Δ
pool/options.go 100.00% <100.00%> (ø)
pool/static_pool.go 71.03% <100.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23c7a6...e636f37. Read the comment docs.

@rustatian rustatian merged commit 6a2c33b into master Feb 9, 2022
@bors bors bot deleted the feat/err_encoder_as_option branch February 9, 2022 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-other Area: other C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant