fix: buffered channel consumed too much memory

[rustatian]

Reason for This PR

ref: roadrunner-server/roadrunner#1830 (comment)

Description of Changes

• remove debug code with an allocation of the big stream channel.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

• All commits in this PR are signed (git commit -s).
• The reason for this PR is clearly provided (issue no. or explanation).
• The description of changes is clear and encompassing.
• Any required documentation changes (code and docs) are included in this PR.
• Any user-facing changes are mentioned in CHANGELOG.md.
• All added/changed functionality is tested.

Summary by CodeRabbit

• Refactor
  • Improved stream handling and response management in the application's background processes.
  • Enhanced logging and state transition mechanisms for better performance and user experience.

[coderabbitai]

Walkthrough

The code revision introduces enhancements to the worker pool's stream management, optimizing the flow of data through new channel mechanisms, fine-tuning buffer capacities, and refining the response processing logic. The changes aim to improve efficiency and stability, while also providing clearer logging for state changes within the system.

Changes

File Path	Summary of Changes
.../workers_pool.go	Introduced stream handling channels, adjusted channel buffer sizes, and updated response handling logic. Improved logging and state management.

🐇✨
To the code we hop and leap,
Channels wide, where streams do sweep.
Through buffers broad and logic neat,
A coderabbit's work, now more complete. 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 15ebfc2 and f6dea40.

Files ignored due to filter (1)

• go.mod

Files selected for processing (1)

• pool/static_pool/workers_pool.go (4 hunks)

Additional comments: 4

pool/static_pool/workers_pool.go (4)

• 241-247: The creation of the buffered channel resp for stream mode has been adjusted to a buffer size of 5. This change seems to be in line with the PR's objective to optimize memory usage. However, it's important to ensure that this new buffer size is sufficient for the expected load and does not introduce backpressure that could affect performance.

• 285-287: The error handling within the stream mode seems to be improved by sending an error payload through the resp channel. This is a good practice as it allows the caller to handle the error appropriately. However, it's crucial to verify that all callers of this method properly handle the error payloads.

• 293-293: Sending the payload through the resp channel in both supervised and non-supervised execution paths is consistent with the stream handling logic. It's important to ensure that the payloads are being consumed and that the channel is not getting blocked, which could lead to memory issues.

Also applies to: 313-313

• 327-329: The creation of the buffered channel resp for req-resp mode with a buffer size of 1 is a significant change. This aligns with the PR's objective to reduce memory consumption. It's important to ensure that this change does not introduce any unexpected behavior or performance degradation.