Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[💡 FEATURE REQUEST]: gRPC plugin custom interceptors #973

Open
rustatian opened this issue Jan 27, 2022 · 3 comments
Open

[💡 FEATURE REQUEST]: gRPC plugin custom interceptors #973

rustatian opened this issue Jan 27, 2022 · 3 comments
Assignees
@rustatian
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. C-feature-request Category: feature requested, but need to be discussed P-GRPC Plugins: GRPC
Milestone
v2025.1.0

Comments

@rustatian
Copy link
Member

Plugin

GRPC

I have an idea!

Like we have middleware in the HTTP plugin, will be nice to have the custom interceptors for the grpc plugin.

# GRPC service configuration
grpc:
  # socket to listen
  listen: "tcp://127.0.0.1:9005"
  interceptors: ["prometheus", "logger" ] <---------

  # proto root file
  proto: "proto/service/service.proto"
  max_send_msg_size: 50
  max_recv_msg_size: 50
  max_connection_idle: 0s
  max_connection_age: 0s
  max_connection_age_grace: 0s
  max_concurrent_streams: 10
  ping_time: 1s
  timeout: 200s

The plugin should support the interceptors from the grpc-go-ecosystem as well.
@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. C-feature-request Category: feature requested, but need to be discussed P-GRPC Plugins: GRPC labels Jan 27, 2022
@rustatian rustatian self-assigned this Jan 27, 2022
@rustatian rustatian moved this to Backlog in General Jan 27, 2022
@rustatian rustatian moved this from Backlog to Discuss in General Jan 27, 2022
@rustatian rustatian mentioned this issue Jun 29, 2022
Closed
6 tasks
@rustatian rustatian moved this from Discuss to Done in General Mar 24, 2023
@rustatian rustatian added this to the v2023.1.0 milestone Mar 24, 2023
@rustatian
Copy link
Member Author

Done: https://github.com/roadrunner-server/grpc/blob/master/common/interfaces.go#L14
Docs are coming.

@github-project-automation github-project-automation bot moved this from Done to Unreleased in General Mar 24, 2023
@rustatian rustatian moved this from Unreleased to Done in General Apr 13, 2023
@rauanmayemir
Copy link

@rustatian Pinging to let you know that config part for this doesn’t exist yet. There is currently no way to plug custom interceptors.

@rustatian rustatian reopened this Sep 16, 2024
@rustatian rustatian modified the milestones: v2023.1.0, v2024.3 Sep 16, 2024
@rustatian rustatian moved this to 🔖 Ready in Jira 😄 Sep 16, 2024
@rustatian
Copy link
Member Author

Ah yeah, forgot to update a configuration. Will be released in 2024.3.

@rustatian rustatian modified the milestones: v2024.3, v2024.3.1 Dec 6, 2024
@rustatian rustatian modified the milestones: v2024.3.1, v2024.3.2 Dec 20, 2024
@rustatian rustatian modified the milestones: v2024.3.2, v2025.1.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. C-feature-request Category: feature requested, but need to be discussed P-GRPC Plugins: GRPC
Projects
Jira 😄
Status: 🔖 Ready
General
Archived in project
Milestone
v2025.1.0
Development

No branches or pull requests
2 participants
@rauanmayemir @rustatian