Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG]: Use amqp queue name as routing key by default #1181

Closed
1 task done
rauanmayemir opened this issue Jun 17, 2022 · 1 comment · Fixed by roadrunner-server/amqp#23
Closed
1 task done

[🐛 BUG]: Use amqp queue name as routing key by default #1181

rauanmayemir opened this issue Jun 17, 2022 · 1 comment · Fixed by roadrunner-server/amqp#23
Assignees
Labels
B-bug Bug: bug, exception D-driver Driver for the RR plugin P-jobs Plugin: Jobs
Milestone

Comments

@rauanmayemir
Copy link

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

If one specifies a pipeline config like this:

jobs:
  pipelines:
    pipeline1:
      driver: amqp
      config:
        queue: queue1
    pipeline2:
      driver: amqp
      config:
        queue: queue2

Both queues will be bound to the direct exchange without routing key. This could lead to issues and even undesirable outcomes when pipelines process different kinds of messages.

I think amqp queue name should be used as a routing key by default.
This way, both pipelines will correctly process their corresponding queues.

Version

2.10.4

Relevant log output

No response

@rustatian rustatian added D-driver Driver for the RR plugin P-jobs Plugin: Jobs and removed F-need-verification labels Jun 17, 2022
@rustatian rustatian moved this to Backlog in General Jun 17, 2022
@rustatian rustatian moved this from Backlog to Todo in General Jun 17, 2022
@rustatian rustatian added this to the v2.10.5 milestone Jun 17, 2022
@rustatian
Copy link
Member

Hey @rauanmayemir 👋🏻
Thanks for the contribution. I will fix this behavior in the 2.10.5 (release cycle - 23.06).

Repository owner moved this from Todo to Unreleased in General Jun 22, 2022
@rustatian rustatian mentioned this issue Jun 23, 2022
6 tasks
@rustatian rustatian moved this from Unreleased to Done in General Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception D-driver Driver for the RR plugin P-jobs Plugin: Jobs
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants