Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛 BUG]: RR hangs on the wait4 syscall when rr reset is using at the same time #1180

Closed
1 task done
rustatian opened this issue Jun 16, 2022 · 0 comments · Fixed by roadrunner-server/sdk#36
Closed
1 task done

[🐛 BUG]: RR hangs on the wait4 syscall when rr reset is using at the same time #1180

rustatian opened this issue Jun 16, 2022 · 0 comments · Fixed by roadrunner-server/sdk#36
Assignees
@rustatian
Labels
B-bug Bug: bug, exception
Milestone
v2.10.6

Comments

@rustatian
Copy link
Member

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

RR uses wait4 syscall to be notified for the PHP process exit. Suppose the user stops the worker for any purpose (syscall or just an internal issue) and is using an rr reset simultaneously. In that case, that will lead to deadlock in the worker_watcher, because one part of the ww will be trying to reallocate the worker while the second part will hold the mutex.

Version

all versions are affected

Relevant log output

No response
@rustatian rustatian added the B-bug Bug: bug, exception label Jun 16, 2022
@rustatian rustatian self-assigned this Jun 16, 2022
@rustatian rustatian moved this to Backlog in General Jun 16, 2022
@rustatian rustatian moved this from Backlog to Todo in General Jun 16, 2022
@rustatian rustatian mentioned this issue Jun 16, 2022
Closed
1 task
@rustatian rustatian added this to the v2.10.5 milestone Jun 17, 2022
@rustatian rustatian changed the title [🐛 BUG]: RR hands on the wait4 syscall when rr reset is using at the same time [🐛 BUG]: RR hangs on the wait4 syscall when rr reset is using at the same time Jun 22, 2022
@rustatian rustatian modified the milestones: v2.10.5, v2.10.6 Jun 26, 2022
@rustatian rustatian mentioned this issue Jul 1, 2022
Merged
6 tasks
@rustatian rustatian moved this from Todo to In Progress in General Jul 1, 2022
Repository owner moved this from In Progress to Unreleased in General Jul 1, 2022
@rustatian rustatian mentioned this issue Jul 7, 2022
Merged
6 tasks
@rustatian rustatian moved this from Unreleased to Done in General Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
B-bug Bug: bug, exception
Projects
No open projects
General
Archived in project
Milestone
v2.10.6
Development

Successfully merging a pull request may close this issue.

chore: worker_watcher refactoring roadrunner-server/sdk
1 participant
@rustatian