Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]: update frame validation error to current version #193

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Kaspiman
Copy link

@Kaspiman Kaspiman commented Sep 1, 2023

Reason for This PR

Current link is outdated!

Description of Changes

Let's use actual link!

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s) or (git commit -S).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review September 1, 2023 22:30
@rustatian rustatian changed the title Update frame validation error to current version [doc]: update frame validation error to current version Sep 1, 2023
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #193 (c136d3e) into master (fd36dce) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files           8        8           
  Lines        1085     1085           
=======================================
  Hits          597      597           
  Misses        449      449           
  Partials       39       39           
Files Changed Coverage Δ
internal/receive.go 63.15% <66.66%> (ø)

@rustatian rustatian merged commit 77ba360 into roadrunner-server:master Sep 1, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Unreleased
Status: SPRINT-21AUG-18SEP
Development

Successfully merging this pull request may close these issues.

2 participants