Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor user heading indicator to typescript #2244

Merged
merged 1 commit into from
Sep 27, 2022
Merged

refactor: Refactor user heading indicator to typescript #2244

merged 1 commit into from
Sep 27, 2022

Conversation

mfazekas
Copy link
Contributor

Refactor user heading indicator to typescript

@mfazekas mfazekas force-pushed the mfazkeas/user-location branch 2 times, most recently from 64580f7 to c28502d Compare September 26, 2022 19:54
@mfazekas mfazekas force-pushed the mfazkeas/user-location branch from c28502d to 96e9fea Compare September 26, 2022 20:05
@mfazekas mfazekas merged commit c399a29 into main Sep 27, 2022
@mfazekas mfazekas deleted the mfazkeas/user-location branch September 27, 2022 03:04
@cameronmurphy
Copy link
Contributor

Could this PR be the reason I am seeing test failures?

  ● Test suite failed to run

    Cannot find module '../../assets/heading.png' from 'node_modules/@rnmapbox/maps/lib/commonjs/components/HeadingIndicator.js'

    Require stack:
      node_modules/@rnmapbox/maps/lib/commonjs/components/HeadingIndicator.js
      node_modules/@rnmapbox/maps/lib/commonjs/components/UserLocation.js
      node_modules/@rnmapbox/maps/lib/commonjs/index.js
      src/scenes/home/components/map/index.js
      src/scenes/home/components/map/index.test.js

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:306:11)
      at Object.<anonymous> (node_modules/@rnmapbox/maps/lib/javascript/HeadingIndicator.tsx:3:1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfazekas @cameronmurphy