Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP/Stackdriver header support #43

Open
fredr opened this issue Jan 16, 2020 · 1 comment
Open

GCP/Stackdriver header support #43

fredr opened this issue Jan 16, 2020 · 1 comment

Comments

@fredr
Copy link

fredr commented Jan 16, 2020

We use GCP as our cloud provider, and for our kubernetes clusters we use the nginx-ingress with opentracing enabled, and we have a zipkin-gcp deployment that upload traces from the ingress to stackdriver.

That works fine, but when a request coming from an other google service like AppEngine, the x-cloud-trace-context-header is set, but since this lib ignores that header, the nginx-ingress trace will not be recored with the same trace-id etc, so they will not get connected.

The outgoing request will also have both the x-cloud-trace-context-header, and the x-b3-*-headers. Making everything confusing for the next service.

Would support for this header be something you could consider adding to this lib? or do you deem it out of scope? or do you see any other way of getting around this without having to write a whole new opentracing lib for stackdriver?

@fredr
Copy link
Author

fredr commented Jan 21, 2020

I've made a (quick and dirty) custom version of the lib, for debuggin, that propagates the x-cloud-trace-context header instead of the b3 headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant