Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generation of 128-bit trace ID #36

Open
trajano opened this issue Sep 28, 2019 · 0 comments · May be fixed by #47
Open

Allow generation of 128-bit trace ID #36

trajano opened this issue Sep 28, 2019 · 0 comments · May be fixed by #47

Comments

@trajano
Copy link

trajano commented Sep 28, 2019

This block of code that generates the trace ID only yields a 64-bit trace ID. Can it return the TraceId object that supports 128-bit?

zipkin-cpp-opentracing/zipkin/src/utility.cc

Line 46 in 2644ca2

uint64_t RandomUtil::generateId() { return getTlsRandomEngine()(); }

Closing opentracing-contrib/nginx-opentracing#112 as it is this module that is generating the ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

128 bit trace ids Wilhansen/zipkin-cpp-opentracing
1 participant
@trajano