Blender closes when rendering while Fluid Particle Debugging is enabled

[PavelBlend]

Hello, @rlguy

System Information

Blender Version (including hash): 2.92.0 02948a2cab44
FLIP Fluids Version: 9.0.9.15
Operating System: Windows-10-10.0.18362-SP0 64 Bits
CPU: AMD A8 5600K with Radeon HD Graphics
GFX: AMD Radeon HD 7560D ATI Technologies Inc. 4.5.13399 Core Profile Context 15.200.1062.1004
RAM: 16 GB

Describe the bug

Blender stably quits on rendering if the Enable Fluid Particle Debugging option is enabled.

To Reproduce

Create a domain, create any fluid source, enable the Enable Fluid Particle Debugging option, bake the fluid, enable F12 rendering. This error occurs in any scene.

Log

crash.txt

[rlguy]

Thanks for the report and crash log! Unfortunately I am not able to reproduce this on my system. It's possible that this issue could be related to AMD GPU hardware as we use Nvidia on our systems.

According to the crash log, the area that the crash is happening is when the addon is using Blender's GPU module to set up the particle shader: https://github.com/rlguy/Blender-FLIP-Fluids/blob/master/src/addon/operators/draw_particles_operators.py#L111

        particle_shader = gpu.types.GPUShader(vertex_shader, fragment_shader)
        particle_shader.uniform_float('pointsize', dprops.debug.particle_size)
        particle_batch_draw = batch_for_shader(
            particle_shader, 'POINTS',
            {"pos": particle_vertices, "color": particle_vertex_colors},
        )

Does this crash also happen in earlier versions of Blender? If there is not a crash in earlier versions, this could be caused by a bug in Blender.

I think a simple workaround for this crash would be if we disabled that section of code during F12 render. The particle drawing does not need to be updated or run during render on Cycles/Eevee.

[PavelBlend]

Does this crash also happen in earlier versions of Blender?

yes. 2.90 has this error too.

My built-in video card often has similar problems. I can't start blender 2.91 due to my graphics card. In version 2.80, particles of the standard particle system were displayed incorrectly.

[dotgamelab]

I have same crash.

https://developer.blender.org/T86261

[rlguy]

I have same crash.

I just had a look at the .blend file attached to issue T86261 and it looks like this crash is unrelated to this issue thread, which is a crash caused by the Fluid Particle Debugging option being enabled.

The problem with the hibye_sim_24.blend file crashing is that the Lock Interface option needs to be enabled:

The addon automatically enables this option when creating a domain and if disabled, this will cause render crashes. Locking the interface is required for stable rendering according to the developers in this issue thread comment: https://developer.blender.org/T60094#773490

Hope this helps!

[rlguy]

I was able to test this bug on our MacOS with a Intel UHD 630 graphics chip. Although there were no crashes, I was getting errors from Blender's GPU module during render. I have added a workaround of disabling the problem code while rendering.

This fix is now available in experimental version 9.0.9.16. If you end up still having crashes, let me know and I can reopen this issue.