-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity 2018.x+ Packge Format #246
Comments
As soon as this happens I think I'll split Steamworks.NET into two, a Unity 2018.x+ version, and a legacy version. I'm really excited for it! |
Is the plan to wait for git URL support then make this change? Should I make a PR for this? |
Yeah, I'd want to wait until we get a little closer! |
https://forum.unity.com/threads/git-support-on-package-manager.573673/#post-3819487 As of Unity 2018.3.0b7, there is now experimental git import support. Would it make much sense to support this now. It should work with the forked repo that I have already created, but I would rather this be officially supported from your end. |
Please make it happen. 2018.3 is now officially released. |
Friendly reminder about this. We're starting to near the 2019.1 release and this is still not open. Should I open a PR? |
I still need to think about this a little bit, I explicitly don't want SteamManager in this repo, because it's Unity specific, where as Steamworks.NET isn't. Would creating a specific branch, or separate repo which has both be best? Or do I need to just give in? What also happens with all the non-Unity files? I don't particularly want to ship any Standalone stuff in there. Any thoughts? |
My thoughts: being one of the non-Unity users of Steamworks.NET, I really do not want Unity-specific files integrated into the main repo. A Unity-specific repo/branch seems like a good idea. |
I would say a repo for unity which implements on Steamworks.NET IMO it's the cleanest way. Branches are for merging and then deleting them. |
For those who are interested in a Unity Package Manager version, I have gone as far as to repackage this project on a public scoped package registry: It should work with scoped repositories supported since Unity 2018.3. |
It'd be great if this was importable as a Unity package. It appears that git URL support for packages is coming in the future.
I've already created a fork with a matching file structure that can be imported as a git submodule, embedded in the Packages folder. Example of how to do this: https://github.com/HouraiTeahouse/FantasyCrescendo/tree/develop/Packages.
I can make a PR out of this if need be.
The text was updated successfully, but these errors were encountered: