Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity 2018.x+ Packge Format #246

Closed
james7132 opened this issue Jul 19, 2018 · 11 comments
Closed

Unity 2018.x+ Packge Format #246

james7132 opened this issue Jul 19, 2018 · 11 comments

Comments

@james7132
Copy link

james7132 commented Jul 19, 2018

It'd be great if this was importable as a Unity package. It appears that git URL support for packages is coming in the future.

I've already created a fork with a matching file structure that can be imported as a git submodule, embedded in the Packages folder. Example of how to do this: https://github.com/HouraiTeahouse/FantasyCrescendo/tree/develop/Packages.

I can make a PR out of this if need be.

@rlabrecque
Copy link
Owner

As soon as this happens I think I'll split Steamworks.NET into two, a Unity 2018.x+ version, and a legacy version. I'm really excited for it!

@james7132
Copy link
Author

Is the plan to wait for git URL support then make this change?

Should I make a PR for this?

@rlabrecque
Copy link
Owner

Yeah, I'd want to wait until we get a little closer!

@james7132
Copy link
Author

https://forum.unity.com/threads/git-support-on-package-manager.573673/#post-3819487

As of Unity 2018.3.0b7, there is now experimental git import support. Would it make much sense to support this now. It should work with the forked repo that I have already created, but I would rather this be officially supported from your end.

@MeikelLP
Copy link

Please make it happen. 2018.3 is now officially released.
I'd love to use this as a package dependency.

@james7132
Copy link
Author

Friendly reminder about this. We're starting to near the 2019.1 release and this is still not open. Should I open a PR?

@rlabrecque
Copy link
Owner

I still need to think about this a little bit, I explicitly don't want SteamManager in this repo, because it's Unity specific, where as Steamworks.NET isn't. Would creating a specific branch, or separate repo which has both be best? Or do I need to just give in? What also happens with all the non-Unity files? I don't particularly want to ship any Standalone stuff in there. Any thoughts?

@KelsamGames
Copy link

KelsamGames commented Feb 21, 2019

My thoughts: being one of the non-Unity users of Steamworks.NET, I really do not want Unity-specific files integrated into the main repo. A Unity-specific repo/branch seems like a good idea.

@MeikelLP
Copy link

I would say a repo for unity which implements on Steamworks.NET

IMO it's the cleanest way. Branches are for merging and then deleting them.

@james7132
Copy link
Author

james7132 commented Oct 19, 2019

For those who are interested in a Unity Package Manager version, I have gone as far as to repackage this project on a public scoped package registry:
https://upm.houraiteahouse.net/-/web/detail/com.rlabrecque.steamworks, based off of the HouraiTeahouse fork, and will be automatically updating it via Travis CI or AppVeyor as updates to the main repo gets updated. It might be possible to set that up off of the main repository as well.

It should work with scoped repositories supported since Unity 2018.3.

@rlabrecque
Copy link
Owner

Progress has been made here:
#414

#389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants