Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate KeyboardTextsTable from templates #436

Open
soshial opened this issue Jan 16, 2024 · 1 comment
Open

Generate KeyboardTextsTable from templates #436

soshial opened this issue Jan 16, 2024 · 1 comment

Comments

@soshial
Copy link
Contributor

soshial commented Jan 16, 2024

The LatinIME keyboard's KeyboardTextsTable can still be generated by templates (see template example here). Here's the generation code for that. Maybe Simple Keyboard should also employ the generation instead of just editing KeyboardTextsTable.java output file which was not recommended?

@rkkr
Copy link
Owner

rkkr commented Jan 21, 2024

The story is that I threw it out of LatinIME along with lots of other stuff when I started the project as I didn't intend to make changes to it. I also never expected to receive a PR into this project.

I don't really have an opinion if it's worth to bring it back. Java file is mostly well commented so if you only need to edit a single KeyHint it's usually easy to find it. If nulls weren't put into long sequences without comments I'd say it's as easy to edit. Adding a new KeyHint isn't easy.

The complication with generation code is that now there's a new project that you need to figure out how to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants