Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle parameterized unit tests. #604

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Handle parameterized unit tests. #604

merged 2 commits into from
Sep 9, 2024

Conversation

rjust
Copy link
Owner

@rjust rjust commented Sep 9, 2024

The expected format for failing tests is: --- <class name>[::<method name>].

This change ensures that the method name of parameterized unit tests does not include [xyz].

@rjust rjust requested a review from mernst September 9, 2024 05:08
mernst
mernst approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It would be good to add a comment to the regular expression, similar to what is in the pull request description.
Thanks!

@rjust rjust merged commit 290d8e4 into java-11-compatibility Sep 9, 2024
2 checks passed
@rjust rjust deleted the formatter-fix branch September 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mernst mernst mernst approved these changes

Assignees

@rjust rjust

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjust @mernst