Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent UI 9: Field component only allows string as label #3946

Closed
3 of 4 tasks
marcveens opened this issue Nov 9, 2023 · 2 comments · Fixed by #3948
Closed
3 of 4 tasks

Fluent UI 9: Field component only allows string as label #3946

marcveens opened this issue Nov 9, 2023 · 2 comments · Fixed by #3948
Labels

Comments

@marcveens
Copy link
Contributor

Prerequisites

What theme are you using?

other

Version

5.13.6

Current Behavior

In SelectWidget.tsx there's a Fluent UI 9 <Field /> component that only allows string or undefined as a label property. labelValue(label, hideLabel) provided by RJSF could also return false or a React component. A ts-expected-error solves it for now.

This is not an issue on implementation level, only for developers of the fluentui-rc package.

Expected Behavior

The ts-expected-error should not be necessary.

Steps To Reproduce

No response

Environment

- OS: macOS Sonoma
- Node: 18.14.0
- npm: 9.3.1

Anything else?

No response

@marcveens marcveens added bug needs triage Initial label given, to be assigned correct labels and assigned labels Nov 9, 2023
@heath-freenome heath-freenome removed the needs triage Initial label given, to be assigned correct labels and assigned label Nov 11, 2023
@heath-freenome
Copy link
Member

@marcveens Looks like we found a fix. Also, since I just released 5.14.0 please push a PR that adds the new theme into the playground! Thanks

@marcveens
Copy link
Contributor Author

Thank you guys!

I've added a PR for adding the theme to the playground, #3951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants