Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground URL should serialize checkboxes as well #1400

Closed
epicfaace opened this issue Aug 12, 2019 · 1 comment · Fixed by #1403
Closed

Playground URL should serialize checkboxes as well #1400

epicfaace opened this issue Aug 12, 2019 · 1 comment · Fixed by #1403
Labels
good first issue playground

Comments

@epicfaace
Copy link
Member

Description

Currently, if I check a checkbox such as "Live validation" or "Omit extra data" and then copy a link from a playground, the link does not encode that I have checked the checkbox. It only encodes the schema, uiSchema, and formData.

Solution

Encode the checkbox values as well, so that links can be more easily shared.
@GrooChu GrooChu mentioned this issue Aug 13, 2019
Merged
7 tasks
@GrooChu
Copy link
Contributor

GrooChu commented Aug 13, 2019

Hi @epicfaace Please check my PR for this issue. #1403 I have tested the changes in my local env and it is working as expected. Let me know if you need anything else. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Encode checkbox settings in playground GrooChu/react-jsonschema-form
2 participants
@epicfaace @GrooChu