Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email::Sender::Transport::SMTP::Persistent should call its disconnect method on destruction #81

Open
abraxxa opened this issue Jun 10, 2022 · 0 comments

Comments

@abraxxa
Copy link

abraxxa commented Jun 10, 2022

When using the SMTP::Persistent transport, the last mail of a connection is dropped by the mail relay connected to, when the disconnect method isn't called.

As the disconnect method only exists for the SMTP::Persistent transport, code that allows configuring the transport would have to check if the transport instance has a disconnect method, and call it if.
As that isn't nice I'd prefer if it gets called automatically when the transport instance is destroyed, end of program in my case.

If that's not safely possible on global destruction, maybe moving the reset from start of next mail to end of mail would fix the problem of dropped last mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant