Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing analysis tests #10

Closed
5 of 6 tasks
Rot127 opened this issue Aug 3, 2021 · 1 comment
Closed
5 of 6 tasks

Missing analysis tests #10

Rot127 opened this issue Aug 3, 2021 · 1 comment
Assignees
@Rot127
Labels
enhancement New feature or request prioritize Increases the qualitiy significantly

Comments

@Rot127
Copy link
Member

Rot127 commented Aug 3, 2021 •
edited
Loading

The rizin tests for the analysis parts are missing. Because of this the tests in rizinorg/rizin#1338 fail.

Minimum they should test for:

  • Correct extension of immediate values by immext instructions.
  • PC relative jumps/calls (forwards and backwards)
  • Hardware loops and their jumps (forwards and backwards)
  • Correct function recognition.
  • Position of an instruction in an instruction package

Optional

  • Cross references (maybe even for strings?)
@Rot127 Rot127 added bug Something isn't working prioritize Increases the qualitiy significantly labels Aug 3, 2021
@Rot127 Rot127 self-assigned this Aug 3, 2021
@Rot127 Rot127 added the enhancement New feature or request label Aug 3, 2021
@Rot127 Rot127 removed the bug Something isn't working label Aug 25, 2021
@Rot127
Copy link
Member Author

Rot127 commented Sep 29, 2021

Tracked by: #27

@Rot127 Rot127 closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rot127 Rot127

Labels
enhancement New feature or request prioritize Increases the qualitiy significantly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rot127