Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should firep and presentation objects store real grades? #99

Open
mlesnick opened this issue Jul 13, 2017 · 0 comments
Open

should firep and presentation objects store real grades? #99

mlesnick opened this issue Jul 13, 2017 · 0 comments

Comments

@mlesnick
Copy link
Contributor

mlesnick commented Jul 13, 2017

The firep class does not store real-valued grade information; this is stored elsewhere. It seems it would be nicer to make the real grades part of the data of the firep object. This would align better with the mathematical definition of firep.

Similarly for presentations.

@mlesnick mlesnick mentioned this issue Oct 3, 2017
@mlesnick mlesnick changed the title firep object should store real grades should firep and presentation objects store real grades? Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant