fix(stream): fix wrong usage of chunk builder in topn #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
commented
Sep 12, 2022
| @@ -204,7 +204,7 @@ impl<S: StateStore> TopNExecutorBase for InnerGroupTopNExecutorNew<S> { | |||
| ) | |||
| .await?; | |||
| } | |||
| // compare the those two ranges and emit the differantial result | |||
xxchan
force-pushed
the
xxchan/helpless-baboon
branch
from
88b3fe7 to
77d352f
Compare
xxchan
force-pushed
the
xxchan/helpless-baboon
branch
from
77d352f to
2392127
Compare
Codecov Report
@@ Coverage Diff @@
## main #5286 +/- ##
==========================================
- Coverage 73.95% 73.95% -0.01%
==========================================
Files 893 893
Lines 137853 138102 +249
==========================================
+ Hits 101950 102127 +177
- Misses 35903 35975 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xxchan
changed the title
st1page
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #5285