Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use debug=line-tables-only #9107

Closed
xxchan opened this issue Apr 11, 2023 · 4 comments · Fixed by #10029
Closed

Use debug=line-tables-only #9107

xxchan opened this issue Apr 11, 2023 · 4 comments · Fixed by #10029
Assignees
@xxchan
Milestone
release-1.0

Comments

@xxchan
Copy link
Member

xxchan commented Apr 11, 2023 •
edited
Loading

debuginfo=1 still contains debug info. line-tables-only can be much smaller. I tested that it's 1.4G -> 844M

See https://github.com/rust-lang/rust/pull/109808/files#diff-6e9a08e032c83ccfc4b967a192b6d38c932eaaf6a153027bd79365830e4d7139

Wait for cargo's support rust-lang/cargo#11958
@github-actions github-actions bot added this to the release-0.19 milestone Apr 11, 2023
@xxchan
Copy link
Member Author

xxchan commented May 23, 2023

available in 04-27/1.71

@xxchan xxchan modified the milestones: release-0.19, release-0.20 May 24, 2023
@xxchan
Copy link
Member Author

xxchan commented May 26, 2023

Wait, why our binaries are already so small now?

-rwxr-xr-x  1 xxchan  staff   446M May 26 22:18 target/ci-dev/risingwave
-rwxr-xr-x  1 xxchan  staff   540M May 26 21:54 target/debug/risingwave
-rwxr-xr-x  1 xxchan  staff   228M May 26 22:16 target/release/risingwave

@xxchan
Copy link
Member Author

xxchan commented May 26, 2023 •
edited
Loading

Linux binaries are larger 😄

-rwxrwxr-x 2 ubuntu ubuntu 1.4G May 26 20:40 target/ci-dev/risingwave*   # after -> 764M
-rwxrwxr-x 2 ubuntu ubuntu 3.1G May 26 20:45 target/debug/risingwave*

@xxchan
Copy link
Member Author

xxchan commented May 26, 2023 •
edited
Loading

I guess this is because of different defaults for split-debuginfo. Well, I guess for linux we don't really want to split debug info..

@xxchan xxchan mentioned this issue May 26, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xxchan xxchan

Labels
None yet
Projects
None yet
Milestone
release-1.0
Development

Successfully merging a pull request may close this issue.

build: debug=1 -> "line-tables-only" risingwavelabs/risingwave
1 participant
@xxchan