Remove vector of bools in vext #622
Open
+484
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 'n produced in here, and I believe it can't be 0.
And the result of this commit run with riscv-vector-tests is in here |
arichardson
reviewed
Nov 27, 2024
| @@ -118,6 +118,17 @@ function bits_to_bool(x : bits(1)) -> bool = bool_bits(x) | |||
| val to_bits : forall 'l, 'l >= 0.(int('l), int) -> bits('l) | |||
| function to_bits (l, n) = get_slice_int(l, n, 0) | |||
|
|
|||
| val flip_bits : forall 'n, 'n >= 0. (int('n), bits('n)) -> bits('n) | |||
| function flip_bits (num : int('n), x : bits('n)) -> bits('n) = { | |||
There was a problem hiding this comment.
It seems like you are always flipping all bits? Can't you just xor with ones()?
If this function is needed with a partial flip, you can simplify that to an xor with ones(n) @ zeros()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #554
emmm...
I will test the code with riscv-vector-tests later...
And to make sure
assert('n > 0);is right