Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWAP8 overlap with REV8.H (GREVI) in Zbp #58

Open
aswaterman opened this issue May 25, 2021 · 4 comments
Open

SWAP8 overlap with REV8.H (GREVI) in Zbp #58

aswaterman opened this issue May 25, 2021 · 4 comments
Labels
Overlap with existing extension

Comments

@aswaterman
Copy link
Member

aswaterman commented May 25, 2021 •
edited
Loading

REV8.H is a subset of the more generalized GREVI instruction. We should coalesce around GREVI-based encodings rather than defining one-off encodings for its subsets. So, my recommendation is to remove SWAP8 from P, then add REV8.H.
@aswaterman aswaterman changed the title SWAP8 overlap with REV8.H in Zbp BITREV/SWAP8 overlap with REV/REV8.H (GREVI) in Zbp May 25, 2021
@jnk0le

This comment has been minimized.

Sign in to view
@aswaterman aswaterman changed the title BITREV/SWAP8 overlap with REV/REV8.H (GREVI) in Zbp SWAP8 overlap with REV8.H (GREVI) in Zbp May 25, 2021
@chuanhua
Copy link
Contributor

chuanhua commented Jul 2, 2021

I will replace SWAP8 with REV8.H from RVB.

@chuanhua
Copy link
Contributor

Release v0.9.7 (0560ad6) adds rev8.h to replace swap8.

@chuanhua chuanhua mentioned this issue Sep 27, 2021
Open
@chuanhua
Copy link
Contributor

Some usability issues are mentioned in #94. I think the comments there are worth considering for how to handle instruction overlaps if the overlaps only happen either for RV32 or RV64, but not both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Overlap with existing extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aswaterman @chuanhua @jnk0le