Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile warnings for SIGALIGN when FLEN is 64 in arch_test.h #304

Closed
ssecatch-w opened this issue Jan 4, 2023 · 3 comments
Closed

Compile warnings for SIGALIGN when FLEN is 64 in arch_test.h #304

ssecatch-w opened this issue Jan 4, 2023 · 3 comments

Comments

@ssecatch-w
Copy link

New arch_test.h, pulled on Jan 3rd, now doubly defines SIGALIGN when FLEN is 64. This generates very verbose compile warnings.
Please remove it from the == 64 clause, since the FLEN > XLEN check fully resolves the issue.

#if FLEN==64
#define FLREG fld
#define FSREG fsd
#define FREGWIDTH 8
#define SIGALIGN 8
#else
#if FLEN==32
#define FLREG flw
#define FSREG fsw
#define FREGWIDTH 4

#endif
#endif

#if FLEN>XLEN
#define SIGALIGN FREGWIDTH
#else
#define SIGALIGN REGWIDTH
#endif

@neelgala
Copy link
Collaborator

This should be fixed by #277

@ssecatch-w
Copy link
Author

Looks like this doubling has been cleaned up in the latest repo. Thanks!

@allenjbaum
Copy link
Collaborator

is fixed, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants