Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.1 的 Release Note 里面包含了一些过时的内容 #407

Closed
X1aomu opened this issue Oct 13, 2020 · 1 comment
Closed

v1.6.1 的 Release Note 里面包含了一些过时的内容 #407

X1aomu opened this issue Oct 13, 2020 · 1 comment
Labels

Comments

@X1aomu
Copy link

X1aomu commented Oct 13, 2020

1.6.1 的 Release Note 中有如下内容。

然而实际上该功能被实现后又被移除(#335)( 00af291 )了🤣,释出的代码中并不包含相关的内容,建议从 Release Note 中移除。

如能自动识别出哪些 feat commit 是这种类似情况的就更好了。

@lotem
Copy link
Member

lotem commented Oct 14, 2020

比較難做徹底。工具自動整理CHANGELOG,下次發佈時還會根據git提交歷史重新寫出來。現在也只能改GitHub抄過去的那段。發佈前功能被撤銷了而提交記錄無法消除的情況以後也不會少見,有工具的侷限性揹鍋,索性不改了。

技術上有個失誤:
00af291 提交記錄裏專門爲此註明了 BREANKING CHANGE 但沒有納入CHANGLOG。

但是原則上忍了。爲了簡化發佈流程,保證發佈還能夠經常進行,必須依靠自動化的工具。

@lotem lotem closed this as completed Oct 14, 2020
@lotem lotem added the wontfix label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants