fix: session storage retrieval for url messes with the url history #5288
Annotations
10 errors and 1 warning
|
Run web-common unit tests:
web-common/src/lib/store-utils/local-storage.ts#L25
ReferenceError: localStorage is not defined
❯ src/lib/store-utils/local-storage.ts:25:28
❯ Timeout._onTimeout src/lib/create-debouncer.ts:9:10
❯ listOnTimeout node:internal/timers:581:17
❯ processTimers node:internal/timers:519:7
This error originated in "src/features/dashboards/url-state/explore-web-view-store.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
This error was caught after test environment was torn down. Make sure to cancel any running tasks before test finishes:
- cancel timeouts using clearTimeout and clearInterval
- wait for promises to resolve using the await keyword
|
|
Run web-common unit tests:
web-common/src/lib/store-utils/local-storage.ts#L25
ReferenceError: localStorage is not defined
❯ src/lib/store-utils/local-storage.ts:25:28
❯ Timeout._onTimeout src/lib/create-debouncer.ts:9:10
❯ listOnTimeout node:internal/timers:581:17
❯ processTimers node:internal/timers:519:7
This error originated in "src/features/dashboards/url-state/explore-web-view-store.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
This error was caught after test environment was torn down. Make sure to cancel any running tasks before test finishes:
- cancel timeouts using clearTimeout and clearInterval
- wait for promises to resolve using the await keyword
|
|
Run web-common unit tests:
web-common/src/lib/store-utils/local-storage.ts#L25
ReferenceError: localStorage is not defined
❯ src/lib/store-utils/local-storage.ts:25:28
❯ Timeout._onTimeout src/lib/create-debouncer.ts:9:10
❯ listOnTimeout node:internal/timers:581:17
❯ processTimers node:internal/timers:519:7
This error originated in "src/features/dashboards/url-state/explore-web-view-store.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
This error was caught after test environment was torn down. Make sure to cancel any running tasks before test finishes:
- cancel timeouts using clearTimeout and clearInterval
- wait for promises to resolve using the await keyword
|
|
Run web-common unit tests:
web-common/src/lib/store-utils/local-storage.ts#L25
ReferenceError: localStorage is not defined
❯ src/lib/store-utils/local-storage.ts:25:28
❯ Timeout._onTimeout src/lib/create-debouncer.ts:9:10
❯ listOnTimeout node:internal/timers:581:17
❯ processTimers node:internal/timers:519:7
This error originated in "src/features/dashboards/url-state/explore-web-view-store.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
This error was caught after test environment was torn down. Make sure to cancel any running tasks before test finishes:
- cancel timeouts using clearTimeout and clearInterval
- wait for promises to resolve using the await keyword
|
|
Run web-common unit tests:
web-common/src/lib/store-utils/local-storage.ts#L25
ReferenceError: localStorage is not defined
❯ src/lib/store-utils/local-storage.ts:25:28
❯ Timeout._onTimeout src/lib/create-debouncer.ts:9:10
❯ listOnTimeout node:internal/timers:581:17
❯ processTimers node:internal/timers:519:7
This error originated in "src/features/dashboards/url-state/explore-web-view-store.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
This error was caught after test environment was torn down. Make sure to cancel any running tasks before test finishes:
- cancel timeouts using clearTimeout and clearInterval
- wait for promises to resolve using the await keyword
|
|
Run web-common unit tests:
web-common/src/features/dashboards/state-managers/actions/dimension-filters.ts#L29
TypeError: Cannot read properties of undefined (reading 'cond')
❯ Module.toggleDimensionValueSelection src/features/dashboards/state-managers/actions/dimension-filters.ts:29:27
❯ AD_BIDS_APPLY_PUB_DIMENSION_FILTER src/features/dashboards/stores/test-data/store-mutations.ts:47:6
❯ src/features/dashboards/stores/test-data/store-mutations.ts:335:37
❯ src/features/dashboards/stores/test-data/store-mutations.ts:335:15
❯ src/features/dashboards/stores/dashboard-stores.ts:58:5
❯ update ../node_modules/svelte/src/runtime/store/index.js:64:7
❯ Module.updateMetricsExplorerByName src/features/dashboards/stores/dashboard-stores.ts:53:3
❯ Module.applyMutationsToDashboard src/features/dashboards/stores/test-data/store-mutations.ts:330:3
❯ src/features/dashboards/proto-state/sparse-proto.spec.ts:105:9
|
|
Run web-common unit tests:
web-common/src/features/dashboards/stores/AdvancedMeasureCorrector.ts#L57
TypeError: Cannot read properties of undefined (reading 'forEach')
❯ AdvancedMeasureCorrector.correctFilters src/features/dashboards/stores/AdvancedMeasureCorrector.ts:57:46
❯ AdvancedMeasureCorrector.correct src/features/dashboards/stores/AdvancedMeasureCorrector.ts:50:10
❯ Function.correct src/features/dashboards/stores/AdvancedMeasureCorrector.ts:46:62
❯ src/features/dashboards/stores/dashboard-stores.ts:538:32
❯ src/features/dashboards/stores/dashboard-stores.ts:58:5
❯ update ../node_modules/svelte/src/runtime/store/index.js:64:7
❯ updateMetricsExplorerByName src/features/dashboards/stores/dashboard-stores.ts:53:3
❯ Object.selectTimeRange src/features/dashboards/stores/dashboard-stores.ts:525:5
❯ AD_BIDS_SET_P7D_TIME_RANGE_FILTER src/features/dashboards/stores/test-data/store-mutations.ts:79:24
❯ src/features/dashboards/stores/test-data/store-mutations.ts:335:37
|
|
Run web-common unit tests:
web-common/src/features/dashboards/stores/AdvancedMeasureCorrector.ts#L110
TypeError: Cannot read properties of undefined (reading 'columns')
❯ AdvancedMeasureCorrector.correctPivot src/features/dashboards/stores/AdvancedMeasureCorrector.ts:110:26
❯ AdvancedMeasureCorrector.correct src/features/dashboards/stores/AdvancedMeasureCorrector.ts:53:10
❯ Function.correct src/features/dashboards/stores/AdvancedMeasureCorrector.ts:46:62
❯ src/features/dashboards/stores/dashboard-stores.ts:222:32
❯ src/features/dashboards/stores/dashboard-stores.ts:58:5
❯ update ../node_modules/svelte/src/runtime/store/index.js:64:7
❯ updateMetricsExplorerByName src/features/dashboards/stores/dashboard-stores.ts:53:3
❯ Object.syncFromUrl src/features/dashboards/stores/dashboard-stores.ts:211:5
❯ src/features/dashboards/proto-state/sparse-proto.spec.ts:107:30
|
|
Run web-common unit tests:
web-common/src/features/dashboards/stores/dashboard-stores.ts#L421
TypeError: Cannot set properties of undefined (setting 'expandedMeasureName')
❯ src/features/dashboards/stores/dashboard-stores.ts:421:27
❯ src/features/dashboards/stores/dashboard-stores.ts:58:5
❯ update ../node_modules/svelte/src/runtime/store/index.js:64:7
❯ updateMetricsExplorerByName src/features/dashboards/stores/dashboard-stores.ts:53:3
❯ Object.setExpandedMeasureName src/features/dashboards/stores/dashboard-stores.ts:420:5
❯ AD_BIDS_OPEN_IMP_TDD src/features/dashboards/stores/test-data/store-mutations.ts:173:24
❯ src/features/dashboards/stores/test-data/store-mutations.ts:335:37
❯ src/features/dashboards/stores/test-data/store-mutations.ts:335:15
❯ src/features/dashboards/stores/dashboard-stores.ts:58:5
|
|
Run web-common unit tests:
web-common/src/features/dashboards/proto-state/sparse-proto.spec.ts#L151
AssertionError: expected { name: 'AdBids_explore', …(18) } to deeply equal { name: 'AdBids_explore', …(9) }
- Expected
+ Received
Object {
+ "activePage": 4,
"contextColumnWidths": Object {
"delta_absolute": 56,
"delta_change": 44,
"percent": 44,
},
"dimensionFilterExcludeMode": Map {},
+ "dimensionThresholdFilters": Array [],
"dimensions": Array [
Object {
"name": "publisher",
},
Object {
"name": "domain",
},
],
"displayName": "AdBids",
"lastDefinedScrubRange": undefined,
"leaderboardContextColumn": "hidden",
+ "leaderboardMeasureName": "impressions",
"measures": Array [
Object {
"expression": "count(*)",
"name": "impressions",
},
Object {
"expression": "avg(bid_price)",
"name": "bid_price",
},
],
"name": "AdBids_explore",
+ "pivot": Object {
+ "active": true,
+ "activeCell": null,
+ "columnPage": 1,
+ "columns": Object {
+ "dimension": Array [],
+ "measure": Array [
+ Object {
+ "id": "impressions",
+ "title": "impressions",
+ "type": "measure",
+ },
+ ],
+ },
+ "expanded": Object {},
+ "rowPage": 1,
+ "rows": Object {
+ "dimension": Array [
+ Object {
+ "id": "TIME_GRAIN_HOUR",
+ "title": "hour",
+ "type": "time",
+ },
+ Object {
+ "id": "publisher",
+ "title": "publisher",
+ "type": "dimension",
+ },
+ ],
+ },
+ "sorting": Array [],
+ },
+ "selectedComparisonDimension": "",
+ "selectedScrubRange": undefined,
+ "selectedTimezone": "UTC",
+ "showTimeComparison": false,
"table": "AdBids_Source",
+ "tdd": Object {
+ "chartType": "default",
+ "expandedMeasureName": "",
+ "pinIndex": -1,
+ },
"temporaryFilterName": null,
}
❯ assertDashboardEquals src/features/dashboards/proto-state/sparse-proto.spec.ts:151:68
❯ src/features/dashboards/proto-state/sparse-proto.spec.ts:114:9
|
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Loading